Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] verify design tokens frontend-platform updates are non-breaking #754

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

@brian-smith-tcril brian-smith-tcril added the create-sandbox open-craft-grove should create a sandbox environment from this PR label Feb 25, 2025
@open-craft-grove
Copy link

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@brian-smith-tcril brian-smith-tcril changed the title [DO NOT MERGE] test build and platform updates [DO NOT MERGE] test design tokens frontend-platform updates are non-breaking Feb 25, 2025
@brian-smith-tcril brian-smith-tcril changed the title [DO NOT MERGE] test design tokens frontend-platform updates are non-breaking [DO NOT MERGE] verify design tokens frontend-platform updates are non-breaking Feb 25, 2025
@brian-smith-tcril brian-smith-tcril force-pushed the test-build-and-platform-updates branch from 51aadf0 to f8fbf91 Compare February 26, 2025 13:27
PR to get a sandbox that tests using design tokens versions
of frontend-build and frontend-platform without changing
this MFE to use design tokens

this is to verify that it is safe to merge the design tokens support
PRs to frontend-build and frontend-platform and that they do
not contain any breaking changes
@brian-smith-tcril brian-smith-tcril force-pushed the test-build-and-platform-updates branch from f8fbf91 to a24d1a7 Compare February 26, 2025 13:28
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.17%. Comparing base (58aa512) to head (a24d1a7).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #754   +/-   ##
=======================================
  Coverage   93.17%   93.17%           
=======================================
  Files         161      161           
  Lines        3401     3401           
  Branches      924      923    -1     
=======================================
  Hits         3169     3169           
  Misses        214      214           
  Partials       18       18           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@open-craft-grove
Copy link

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@PKulkoRaccoonGang PKulkoRaccoonGang added create-sandbox open-craft-grove should create a sandbox environment from this PR and removed create-sandbox open-craft-grove should create a sandbox environment from this PR labels Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
create-sandbox open-craft-grove should create a sandbox environment from this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants