-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Enable transcripts for video library [FC-0076] #1596
Merged
ChrisChV
merged 12 commits into
openedx:master
from
open-craft:chris/FAL-3989-video-transcripts
Feb 21, 2025
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
b7fbac9
feat: Enable transcripts for video library
ChrisChV 627b4af
test: Enable transcript in libraries
ChrisChV a82e796
test: Adding tests for updateTranscriptHandlerUrl
ChrisChV 9c4a930
feat: Suppor delete and replace transcripts in library
ChrisChV 73c4bda
feat: enable download, replace and update transcripts in library
ChrisChV 729780e
Merge branch 'master' into chris/FAL-3989-video-transcripts
ChrisChV 9f74c07
refactor: use getState once in requests.js functions
ChrisChV 4961e73
refactor: trascriptXblockV2 to transcriptXblockV2 in urls
ChrisChV 91b4a9d
refactor: delete getTranscriptDownloadUrlV2 and add it to getTranscri…
ChrisChV e23367e
style: Fix coverage
ChrisChV 83dc105
Merge branch 'master' into chris/FAL-3989-video-transcripts
ChrisChV ab97463
refactor: useSelector to get isLibrary in TranscriptWidget
ChrisChV File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(out of scope for this issue) The Transcripts part of this
VideoPreviewWidget
is hard to use 😞It also doesn't prevent me from clicking "Save", and so if an upload / replace / delete for a transcript fails, I don't know about it until I re-open the modal.
I have to save, and the re-edit to see all languages for the imported transcripts.
Do we have budget for a follow-up task to fix this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @pomegranited for listing this issues. It will be very helpful!
I think so, I have to evaluate it.