Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: forms #656

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

fix: forms #656

wants to merge 13 commits into from

Conversation

narduin
Copy link
Contributor

@narduin narduin commented Jan 23, 2025 •
edited
Loading

@netlify Netlify
Copy link

netlify bot commented Jan 23, 2025 •
edited
Loading

✅ Deploy Preview for ecospheres ready!

Name Link
🔨 Latest commit 6e4a90a
🔍 Latest deploy log https://app.netlify.com/sites/ecospheres/deploys/67b7566aa065f00008a243eb
😎 Deploy Preview https://deploy-preview-656--ecospheres.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Jan 23, 2025 •
edited
Loading

✅ Deploy Preview for meteo-france ready!

Name Link
🔨 Latest commit 6e4a90a
🔍 Latest deploy log https://app.netlify.com/sites/meteo-france/deploys/67b7566a3a94090008084987
😎 Deploy Preview https://deploy-preview-656--meteo-france.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@narduin
fix(forms): add description for DS title
54b6f22
@narduin
fix(a11y forms): better form accessibility
b0ce262 
add search role or tag
fix type on pages with search (not always form related)
@narduin
fix(a11y forms): accessibility fixes for DatasetAddToBouquetModal
c6c2e19
@narduin
fix(a11y forms): clean DatasetAddToBouquetModal
86e4de4
@narduin
fix(a11y forms): fix types
9252d75
@narduin
fix(a11y forms): refactor validation
13fbab1 
create a composable for error handling
create a component for error summary
@narduin
fix(a11y forms): refactor validation
c38365e 
Create error message component
Handle error messages inside composable
Handle form validation inside DatasetEditModal
abulte
abulte reviewed Feb 18, 2025
View reviewed changes
@narduin narduin marked this pull request as ready for review February 20, 2025 10:06
@narduin narduin requested a review from abulte February 20, 2025 10:06
abulte
abulte reviewed Feb 20, 2025
View reviewed changes
Copy link
Contributor

@abulte abulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 💅

Il manque deux validations dans le formulaire d'ajout / édition d'un jeu de données dans un bouquet :

  • Ni jeu de données ni bouton radio sélectionné
  • "J'ajoute l'URL" sélectionné : URL obligatoire
Capture d’écran 2025-02-20 à 14 02 04 Capture d’écran 2025-02-20 à 14 01 19

@narduin
fix(a11y forms): validation
e504464 
add validation rules for dataset availability
use aria-errormessage where relevant
harmonize error messages editorial tone
@narduin narduin requested a review from abulte February 20, 2025 14:58
abulte
abulte reviewed Feb 20, 2025
View reviewed changes
Copy link
Contributor

@abulte abulte left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Est-ce qu'on peut faire porter la border de l'erreur sur les deux champs (jeu de données + checkbox) ? Ou au pire deux borders.

Et changer le message vers "Un jeu de données ou une disponibilité doit être sélectionné."

Also la border bave est tronquée, mais ça ne sera plus le cas si on change.

Capture d’écran 2025-02-20 à 16 08 47

@narduin
Copy link
Contributor Author

narduin commented Feb 20, 2025

Est-ce qu'on peut faire porter la border de l'erreur sur les deux champs (jeu de données + checkbox) ? Ou au pire deux borders.

Je vais regarder ce qu'on peut faire avec les input, ça me paraissait bizarre de mettre une erreur sur un champ facultatif mais effectivement c'est pas hyper explicite comme ça.

Et changer le message vers "Un jeu de données ou une disponibilité doit être sélectionné."
👍

@narduin narduin requested a review from abulte February 20, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abulte abulte Awaiting requested review from abulte

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Appliquer les correctifs aux formulaires Ajout explication pour le libellé sur page ajout JDD dans bouquets
2 participants
@narduin @abulte