[DASH SAI] Add ENI mode VM/FNIC and trusted_vni entry #2158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @jimmyzhai for the PR. @mukeshmv , @marian-pritsak for review |
|
@jimmyzhai , can you also provide global trusted vni range support for appliance table? |
Signed-off-by: Junhua Zhai <junhua.zhai@outlook.com>
Yes, I'm doing it. |
Signed-off-by: Junhua Zhai <junhua.zhai@outlook.com>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| * | ||
| * @objects SAI_OBJECT_TYPE_ENI | ||
| */ | ||
| sai_object_id_t eni_id; |
There was a problem hiding this comment.
The HLD allows for a global list of trusted VNIs associated with the appliance instead of a specific VNI (https://github.com/sonic-net/SONiC/blob/master/doc/dash/dash-sonic-hld.md#328-appliance), how do we plan to handle this if eni_id is part of the entry definition? @prsunny
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.