Add DSCP resolution from TC in packet trim #2155
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
please provide meaningful description to PR |
marian-pritsak
commented
Mar 20, 2025
| * @brief Dynamic DSCP resolution. | ||
| * | ||
| * In this mode, a new DSCP for the trimmed packet is resolved from the new TRIM_TC | ||
| * set by the application using per-port TC_TO_DSCP mapping |
There was a problem hiding this comment.
The saiqosmap.h defines only TC_AND_COLOR_TO_DSCP map, but no TC_TO_DSCP map, as part of the set of valid qos maps. In this case, a color value also need to be supplied if this mechanism is desired. Could you please clarify ?
SAI_QOS_MAP_TYPE_TC_AND_COLOR_TO_DSCP = 0x00000005,
There was a problem hiding this comment.
Color does not need to be supplied. The user can just map all the colors to same DSCP, since the TC is used for trimming.
marian-pritsak
force-pushed
the
trim-tc
branch
2 times, most recently
from
d94f37a to
5123b4e
Compare
kperumalbfn
reviewed
Mar 25, 2025
inc/saiswitch.h
Outdated
| SAI_SWITCH_ATTR_PACKET_TRIM_TC_VALUE, | ||
|
|
||
| /** | ||
| * @brief Queue mapping mode for a trimmed packet |
There was a problem hiding this comment.
Typo: DSCP mapping mode
There was a problem hiding this comment.
Thanks, fixed.
kperumalbfn
approved these changes
Mar 25, 2025
marian-pritsak
force-pushed
the
trim-tc
branch
3 times, most recently
from
eb30c0b to
a956e66
Compare
Signed-off-by: Marian Pritsak <marianp@mellanox.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.