Update comments for few macsec sa stats to make clear it is cummulative #2136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcudnik
reviewed
Jan 27, 2025
Signed-off-by: Judy Joseph <jujoseph@microsoft.com>
judyjoseph
force-pushed
the
update_macsec_attr_comments
branch
from
33decea to
f097169
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
WARNING: Word 'InPktsInvalid' is misspelled saimacsec.h 968: * statistics InPktsInvalid. |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 2136 in repo opencomputeproject/SAI |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@JaiOCP - please help sign off on this |
|
please fix build errors |
@kcudnik - could you please suggest how to address this? The words are not misspelled |
|
Add them to aspell.en |
@judyjoseph - could you please try this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the comments of few SA stats viz. SAI_MACSEC_SA_STAT_IN_PKTS_INVALID, SAI_MACSEC_SA_STAT_IN_PKTS_NOT_USING_SA, SAI_MACSEC_SA_STAT_IN_PKTS_UNUSED_SA, SAI_MACSEC_SA_STAT_IN_PKTS_OK, SAI_MAC to make it clear that these stats are cumulative as other attributes.