dont install when packaging at all #1371
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
handle-dependencies module will, among other things, install missing dependencies if found. This only makes sense for when running
oc dev
, since you want to replicate the behaviour of a real registry, where the dependencies are served by the registry (in this case the parent folder where oc dev is running from), but it's not needed when packaging/publishing, since there is no registry running involved.Because both commands (dev/package) use the same file, they share the same logic and did the same. This resulted in somebody having an issue when doing this install on CI (#943), and then a new variable was created, useComponentDependencies, to not install when packaging, but rather doing a symlink. But this wasn't needed at all, since AFAIK packaging doesn't require those dependencies anyways. So this PRs removes that option, the logic to symlink, and simplifies by having an internal
install
option that will be true foroc dev
, but false foroc package
andoc publish