Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dont install when packaging at all #1371

Merged
merged 1 commit into from
Aug 3, 2024

Conversation

ricardo-devis-agullo
Copy link
Collaborator

handle-dependencies module will, among other things, install missing dependencies if found. This only makes sense for when running oc dev, since you want to replicate the behaviour of a real registry, where the dependencies are served by the registry (in this case the parent folder where oc dev is running from), but it's not needed when packaging/publishing, since there is no registry running involved.

Because both commands (dev/package) use the same file, they share the same logic and did the same. This resulted in somebody having an issue when doing this install on CI (#943), and then a new variable was created, useComponentDependencies, to not install when packaging, but rather doing a symlink. But this wasn't needed at all, since AFAIK packaging doesn't require those dependencies anyways. So this PRs removes that option, the logic to symlink, and simplifies by having an internal install option that will be true for oc dev, but false for oc package and oc publish

@ricardo-devis-agullo ricardo-devis-agullo merged commit 602afbb into master Aug 3, 2024
3 checks passed
@ricardo-devis-agullo ricardo-devis-agullo deleted the dont-install-when-packaging branch August 3, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant