Skip to content
This repository was archived by the owner on Dec 27, 2023. It is now read-only.

Optional Configuration For Custom Webpack Loaders #162

Merged
merged 5 commits into from
Mar 1, 2018
Merged

Conversation

themoch
Copy link
Contributor

@themoch themoch commented Mar 1, 2018

PR to address issue #161

What

Allows a developer to add rules for webpack that are specific to their component without forking and maintaining a private oc-template

Updates

  • added params to options passed into compiler
  • created check for customWebpackRules
    • uses rules if they exist

@codecov
Copy link

codecov bot commented Mar 1, 2018

Codecov Report

Merging #162 into master will increase coverage by 0.12%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #162      +/-   ##
==========================================
+ Coverage   96.78%   96.91%   +0.12%     
==========================================
  Files          15       17       +2     
  Lines         218      227       +9     
  Branches       23       24       +1     
==========================================
+ Hits          211      220       +9     
  Misses          7        7
Impacted Files Coverage Δ
...bstract-base-template-utils/webpackConfigurator.js 100% <100%> (ø) ⬆️
...ct-component-with-css/customWebpackRules.config.js 100% <100%> (ø)
mocks/react-component/customWebpackRules.config.js 100% <100%> (ø)
...ages/oc-template-react-compiler/lib/compileView.js 98.43% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70973ae...779a7ac. Read the comment docs.

@kmcrawford kmcrawford merged commit f16aaba into master Mar 1, 2018
@matteofigus matteofigus deleted the custom-rules branch August 2, 2018 23:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants