Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add messaging semantic conventions for settlement spans #661

Merged

Conversation

pyohannes
Copy link
Contributor

Fixes #621

Changes

This PR adds conventions around span structure for instrumenting settlement operations in messaging workflows. Those conventions have been agreed on in OTEP 220.

Note that the messaging workgroup agreed to exempt conventions around settlement from initial stability of messaging semantic conventions, those will remain experimental while other parts of semantic conventions will be declared stable.

Merge requirement checklist

@pyohannes pyohannes requested review from a team January 22, 2024 13:50
@pyohannes pyohannes changed the title Add settle spans from OTEP 220 Add messaging semantic conventions for settlement spans Jan 22, 2024
Copy link
Contributor

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pyohannes pyohannes force-pushed the messaging-settlement-span branch from 9a06d2e to 4c5656a Compare January 29, 2024 10:35
@pyohannes
Copy link
Contributor Author

@open-telemetry/semconv-messaging-approvers, please have a look.

@joaopgrassi
Copy link
Member

Hi @pyohannes !

We changed how the CHANGELOG.md is managed. Please take a look at https://github.com/open-telemetry/semantic-conventions/blob/main/CONTRIBUTING.md#adding-a-changelog-entry to see what needs to be done. Sorry for the disruption.

@pyohannes pyohannes force-pushed the messaging-settlement-span branch from 9a6f033 to 23580f5 Compare February 6, 2024 10:15
@joaopgrassi joaopgrassi merged commit be0cae0 into open-telemetry:main Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add conventions for settlement spans for messaging
8 participants