-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add messaging semantic conventions for settlement spans #661
Add messaging semantic conventions for settlement spans #661
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
9a06d2e
to
4c5656a
Compare
@open-telemetry/semconv-messaging-approvers, please have a look. |
Hi @pyohannes ! We changed how the CHANGELOG.md is managed. Please take a look at https://github.com/open-telemetry/semantic-conventions/blob/main/CONTRIBUTING.md#adding-a-changelog-entry to see what needs to be done. Sorry for the disruption. |
9a6f033
to
23580f5
Compare
Fixes #621
Changes
This PR adds conventions around span structure for instrumenting settlement operations in messaging workflows. Those conventions have been agreed on in OTEP 220.
Note that the messaging workgroup agreed to exempt conventions around settlement from initial stability of messaging semantic conventions, those will remain experimental while other parts of semantic conventions will be declared stable.
Merge requirement checklist
schema-next.yaml updated with changes to existing conventions.