model/profile: add frame.type for Go and Rust #2003
+42
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
florianl
force-pushed
the
profile-frame-types++
branch
from
43d6bcc to
302fe16
Compare
christos68k
reviewed
Mar 18, 2025
| @@ -39,12 +39,14 @@ They may be used in any Profiles record they apply to. | |||
| | `beam` | [Erlang](https://en.wikipedia.org/wiki/BEAM_(Erlang_virtual_machine)) |  | | |||
| | `cpython` | [Python](https://wikipedia.org/wiki/Python_(programming_language)) |  | | |||
| | `dotnet` | [.NET](https://wikipedia.org/wiki/.NET) |  | | |||
| | `go` | [Go](https://wikipedia.org/wiki/Go_(programming_language)), |  | | |||
There was a problem hiding this comment.
Should we clarify whether this should be used for symbolized frames only (otherwise 'native'), or could it span both symbolized and unsymbolized (which is what's implied with the current wording)?
For simplicity, symbolization shouldn't affect semantics, and frame type == go should be used whenever the producer can determine that this is the case regardless of presence of symbols.
There was a problem hiding this comment.
If the producer can distinguish in more detail the frame type, go must be preferred over native. Regardless whether the frame is symbolized or not.
Co-authored-by: Christos Kalkanis <christos.kalkanis@elastic.co>
florianl
force-pushed
the
profile-frame-types++
branch
from
735bc89 to
ec2a3d0
Compare
christos68k
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add additional frame.type attributes for Go and Rust. With upcoming changes in https://github.com/open-telemetry/opentelemetry-ebpf-profiler it will be possible to differentiate more granularity on native frames.
FYI @open-telemetry/profiling-maintainers
Merge requirement checklist
[chore]schema-next.yaml updated with changes to existing conventions.