Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcs] add organization and vendor name VCS attributes #1997

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[vcs] add organization and vendor name VCS attributes #1997

wants to merge 2 commits into from

Conversation

afonsonf
Copy link

@afonsonf afonsonf commented Mar 16, 2025 •
edited
Loading

Fixes #1452

Changes

Add organization and vendor name to VCS attribute list

Merge requirement checklist

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Mar 16, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@github-actions github-actions bot added the enhancement New feature or request label Mar 16, 2025
@afonsonf afonsonf marked this pull request as ready for review March 17, 2025 10:18
@afonsonf afonsonf requested review from a team as code owners March 17, 2025 10:18
@kamphaus
Copy link
Contributor

Content-wise it looks good to me.
However there are a few failing checks that have to be fixed before this PR can be merged.

afonsonf added 2 commits March 17, 2025 22:06
@afonsonf
[vcs] add organization and vendor name VCS attributes
095550b 
Signed-off-by: Afonso Fernandes <21228942+afonsonf@users.noreply.github.com>
@afonsonf
fix: pipeline checks
69e67f8 
Signed-off-by: Afonso Fernandes <21228942+afonsonf@users.noreply.github.com>
@afonsonf afonsonf force-pushed the 1452-add-organization-and-vendor-name-to-vcs-attributes branch from ff5a94d to 69e67f8 Compare March 17, 2025 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamphaus kamphaus kamphaus approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Semantic Conventions Triage
Status: Needs More Approval
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add organization name to attribute list when entity definition becomes clearer
2 participants
@afonsonf @kamphaus