Add Browser Resource Timing Event #1943
Conversation
| - id: connectStart | ||
| type: double | ||
| stability: development | ||
| brief: > |
There was a problem hiding this comment.
need to reformat/shorten the brief to make the generated table look nicer
| If the page starts unloading before the page loads, | ||
| then the partial data can be captured by calling the [performance.getEntriesByType](https://developer.mozilla.org/en-US/docs/Web/API/Performance/getEntriesByType) method. | ||
|
|
||
| body: |
There was a problem hiding this comment.
I would like to see a comment here to clarify that this is temporary or that this will actually be an attribute. That way readers do not expect to find content in the actual body.
| stability: development | ||
| type: map | ||
| fields: | ||
| - id: name |
There was a problem hiding this comment.
I don't think name is the right thing for a url here. Maybe just url would be more concise?
There was a problem hiding this comment.
Yeah, now that url.full is stable maybe we should consider lifting this to a top level attribute, where from an instrumentation perspective it would include the full redacted query string -- although for this event you "generally" don't need the full url, just the scheme, domain and path -- but splitting out to 3 different attributes doesn't really fit the need of this event....
Lets change this to url and add wording that it explicitly doesn't include the query string or any leading credentials (so it's formatted as <scheme>:\\<full domain>\<path> only
What I mean by this is that
https://username:password@www.example.com/path?a=b&c=d would be sent as https://www.example.com/path basically both removing any potential PII and reducing the cardinality of the name.
Fixes #
Changes
Please provide a brief description of the changes here.
Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.
Merge requirement checklist
[chore]