Add Browser Web Vitals Event #1940
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breedx-splk
reviewed
Mar 4, 2025
| name: browser.web_vital | ||
| brief: > | ||
| This event describes the website performance metrics introduced by Google, See [web vitals](https://web.dev/vitals). | ||
| body: |
There was a problem hiding this comment.
I would like to see a comment here to clarify that this is temporary or that this will actually be an attribute. That way readers do not expect to find content in the actual body.
MSNev
approved these changes
Mar 11, 2025
trask
reviewed
Mar 13, 2025
Comment on lines
+40
to
+43
| | `cls` | Cumulative Layout Shift. |  | | ||
| | `fid` | First Input Delay. |  | | ||
| | `inp` | Interation to Next Paint. |  | | ||
| | `lcp` | Largest Contentful Paint. |  | |
There was a problem hiding this comment.
are these values (e.g. cls) coming from the browser / browser spec, or are we creating them?
Comment on lines
+31
to
+34
| | `delta` | double | The delta between the current value and the last-reported value. | `0.2` | `Required` |  | | ||
| | `id` | string | A unique ID representing this particular metric instance. | `v3-1677874579383-6381583661209` | `Required` |  | | ||
| | `name` | enum | Name of the web vital. | `cls` | `Required` |  | | ||
| | `value` | double | Value of the web vital. | `1.0` | `Required` |  | |
There was a problem hiding this comment.
did you consider cls.delta, cls.id, cls.value etc?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Changes
Please provide a brief description of the changes here.
Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.
Merge requirement checklist
[chore]