Add browser page view event #1910
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
trask
reviewed
Mar 13, 2025
Comment on lines
+43
to
+44
| | `0` | Initial page load within the browser which will generally also precede a PageNavigationTiming event. |  | | ||
| | `1` | This is for Single Page Applications (SPA) where the framework provides the ability to perform client side only page "navigation", the exact definition of what a virtual page change is determined by the SPA and the framework it is using. |  | |
There was a problem hiding this comment.
do these values (0 and 1) come from the browser / browser spec, or did we create them?
|
|
||
| | Body Field | Type | Description | Examples | [Requirement Level](https://opentelemetry.io/docs/specs/semconv/general/attribute-requirement-level/) | Stability | | ||
| |---|---|---|---|---|---| | ||
| | `change_state` | string | Type of state change used for the virtual page navigation | `pushState`; `replaceState` | `Recommended` |  | |
There was a problem hiding this comment.
just from my reading of the description this could be better?
Suggested change
| | `change_state` | string | Type of state change used for the virtual page navigation | `pushState`; `replaceState` | `Recommended` |  | | |
| | `state_change` | string | Type of state change used for the virtual page navigation | `pushState`; `replaceState` | `Recommended` |  | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This adds a new event for capturing the page view event from browser/web applications.
Merge requirement checklist
[chore]