Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add organization name to attribute list when entity definition becomes clearer #1452

Open
2 tasks
adrielp opened this issue Oct 5, 2024 · 5 comments · May be fixed by #1997
Open
2 tasks

Add organization name to attribute list when entity definition becomes clearer #1452

adrielp opened this issue Oct 5, 2024 · 5 comments · May be fixed by #1997
Labels
good first issue Good for newcomers

Comments

@adrielp
Copy link
Contributor

adrielp commented Oct 5, 2024 •
edited
Loading

Overview

Update semantic conventions to contain the following resource attributes.

Ensure these attributes won't be misaligned with new entity definitions of attributes.

  • vcs.owner.name - the group owner within the version control system. (ie. myorg, myteam)
  • vcs.vendor.name - the vendor name of the version control system. (ie. github/gitlab)
@adrielp adrielp converted this from a draft issue Oct 5, 2024
@adrielp adrielp mentioned this issue Oct 5, 2024
Merged
5 tasks
@christophe-kamphaus-jemmic
Copy link
Contributor

From discussion #1383 (comment)

@lmolkova lmolkova assigned lmolkova and unassigned reyang and lmolkova Oct 21, 2024
@adrielp adrielp mentioned this issue Nov 7, 2024
Closed
@adrielp
Copy link
Contributor Author

adrielp commented Nov 7, 2024

Include:

Discuss & add based on https://github.com/open-telemetry/semantic-conventions/pull/1383/files?short_path=9b51d2f#r1823727031

Team and repository name/state attributes.

Closed
6 tasks
@adrielp
Copy link
Contributor Author

adrielp commented Nov 28, 2024

After discussion in the CICD SIG on Nov. 28th, 2024, we discussed that the potential best path forward for this attribute is vcs.owner.name instead of organization.name. This would be usable across the all vendors, and vendor extensions could come (GitLab group / sub-group for example) that can be added. But across all vendors, having the ownership identifier would be ideal.

CC. @christophe-kamphaus-jemmic

@adrielp
Copy link
Contributor Author

adrielp commented Jan 16, 2025

This has been updated to reflect the information and should be good to pick up!

@adrielp adrielp added the good first issue Good for newcomers label Jan 23, 2025
@afonsonf
Copy link

Hello, I'm a new contributor to OpenTelemetry and I'd like to take on this issue
I've already begun exploring the issue and I plan to submit a draft PR for initial review in the coming days

@afonsonf afonsonf linked a pull request Mar 16, 2025 that will close this issue
Open
3 tasks
@adrielp adrielp moved this from Todo to In Progress in CI/CD SemConv SIG Board Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
CI/CD SemConv SIG Board
Status: In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[vcs] add organization and vendor name VCS attributes afonsonf/semantic-conventions
5 participants
@lmolkova @reyang @afonsonf @adrielp @christophe-kamphaus-jemmic