Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nudge to PR actions #6578

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

theletterf
Copy link
Member

@theletterf theletterf commented Mar 20, 2025

This PR adds a /nudge action that relies on gh run rerun: https://cli.github.com/manual/gh_run_rerun

The idea is addressing the need for rerunning checks after a /fix command. I wonder if adding this command at the end of all fix commands could also solve the situation.

Might potentially fix #4339

@theletterf theletterf requested a review from a team as a code owner March 20, 2025 09:57
@theletterf theletterf self-assigned this Mar 20, 2025
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! ✨

Have you tested this locally? I did, and the rerun request doesn't seem to be doing anything in GH (see inline comment for details):

$ gh run rerun $RUNID                                                                                                                    
✓ Requested rerun of run 13966456806

Edit: reruns seem to get created, but they (1) don't seem to be picking up the latest commits to the branch; (2) the status of the rerun checks don't appear on the PR itself.

@theletterf
Copy link
Member Author

/fix:format

@opentelemetrybot
Copy link
Collaborator

You triggered fix:format action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/13969072963

@opentelemetrybot
Copy link
Collaborator

fix:format failed or was cancelled. For details, see https://github.com/open-telemetry/opentelemetry.io/actions/runs/13969072963.

@theletterf
Copy link
Member Author

@chalin I reviewed the action and went for a simpler approach, that is, creating and pushing an empty commit on demand. As we squash commits when merging PRs, this adds no noise to the git history of main and avoids complex checks-checking logic.

@chalin
Copy link
Contributor

chalin commented Mar 21, 2025

As we talked about out-of-band, I'd tried that approach before, but GH would fail to rerun checks for empty commits. But if you can get it to work, that would be great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[CI] Running /fix:cmd over a PR rebuilds but skips GH action checks
3 participants