-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[javascript] move to SDK 2.x #6441
[javascript] move to SDK 2.x #6441
Conversation
f69693e
to
947200b
Compare
@@ -271,13 +271,12 @@ Add the following to your `package.json`: | |||
"@google-cloud/functions-framework": "^3.0.0", | |||
"@opentelemetry/api": "^1.9.0", | |||
"@opentelemetry/auto-instrumentations-node": "^0.56.1", | |||
"@opentelemetry/exporter-trace-otlp-http": "^0.57.2", | |||
"@opentelemetry/instrumentation": "^0.57.2", | |||
"@opentelemetry/sdk-node": "^0.57.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note for reviewers: this dependency was removed on purpose - it is not used in the above code so it can be safely dropped, which will reduce install size 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from a copy edit perspective.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like the duplication of information that exists in this page and https://github.com/open-telemetry/opentelemetry-js?tab=readme-ov-file#supported-runtimes. We should address this at some point (not in the scope of this PR).
@chalin @tiffany76 2.0.0/0.200.0 is live - this is now unblocked 🙂 Thank you all for your help! 🙌 |
Thanks, @pichlermarc! |
This PR updates the docs to the latest
2.0.0/0.200.0
release of the OTel JS SDK.Closes #6396
Refs open-telemetry/opentelemetry-js#5362
Refs open-telemetry/opentelemetry-js#5148
Notable changes in the docs:
new Resource({...})
->resourceFromAttributes({...}
Resource.empty()
->emtpyResource()
Resource.default()
->defaultResource()
new View({...})
has been replaced by just{...}
aggregation
stops using theAggregation
class and extensions of it, it has been replaced by a typeAggregationOption
that looks like this:{type: AggregationType.EXPLICIT_BUCKET_HISTOGRAM, options: {...}}
Preview: https://deploy-preview-6441--opentelemetry.netlify.app/docs/languages/js/