Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI/i18n] Streamline includes and fix pt Aviso #6398

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Feb 21, 2025

  • Contributes to Improved i18n support #4467
  • Drops markdownlint check for a title so that we don't need to include one in included files. I doubt we've every had someone include a regular doc page without a title. (In any case, I'll look into creating a custom rule later if ever this becomes an issue).
  • Greatly streamlines the "includes" features by making use of targeted cascades across (multilingual) sites
    • Deletes all **/_includes/_index.md files since we no longer need them
    • Drops bogus titles from all includes files
  • Moves content/en/docs/languages/js/_browser-instrumentation-warning.md back into an includes folder since this will be required moving forward.
  • Because of recent past changes to the includes, the pt aviso for JS pages wasn't being picked up, instead the English version was displayed, this is now fixed.

Previews:

Proof that no _includes resources/pages are getting generated:

$ find public -name "_includes*" | wc -l
       0

Also, https://deploy-preview-6398--opentelemetry.netlify.app/_includes/ is a 404.

@chalin chalin added CI/infra CI & infrastructure i18n Internationalization and localization lang:pt labels Feb 21, 2025
@chalin chalin requested a review from a team as a code owner February 21, 2025 20:35
@opentelemetrybot opentelemetrybot requested review from a team February 21, 2025 20:35
Copy link
Contributor

@tiffany76 tiffany76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM.

@chalin chalin merged commit 1ececa0 into open-telemetry:main Feb 21, 2025
18 checks passed
@chalin chalin deleted the chalin-im-rw-streamline-includes-etc-2025-02-21 branch February 21, 2025 20:51
@chalin chalin mentioned this pull request Feb 21, 2025
54 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/infra CI & infrastructure i18n Internationalization and localization lang:pt sig:javascript
Projects
Development

Successfully merging this pull request may close these issues.

2 participants