-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NServiceBus OpenTelemetry integration #6358
Conversation
@irinascurtu can you sign the CLA? They we can review. |
Seems to be fine now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me overall, I would like @svrnm to weigh in on the type field.
I left only instrumentation there |
/fix:all |
You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/13459162673 |
@irinascurtu to resolve the issues with registry validation, these are the errors:
|
IMPORTANT: (RE-)RUN
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See inline comments, and please address validation failures.
@chalin |
@svrnm - when you have a moment, could you help out here? |
Commented on the issue, there is a dash that needs to be removed otherwise the url and name are treated as 2 different authros. @irinascurtu apologies for the delay/slowness on my end, I am currently only able to provide limited availability |
/fix:format |
You triggered fix:format action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/13844840417 |
IMPORTANT: (RE-)RUN
|
/fix:format |
You triggered fix:format action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/13893418453 |
IMPORTANT: (RE-)RUN
|
Co-authored-by: Severin Neumann <severin.neumann@altmuehlnet.de>
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
Co-authored-by: Severin Neumann <severin.neumann@altmuehlnet.de>
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
removed comments
Waiting for @svrnm's final approval. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
Thank you for your contribution! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey |
No description provided.