Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NServiceBus OpenTelemetry integration #6358

Merged
merged 15 commits into from
Mar 20, 2025
Merged

Conversation

irinascurtu
Copy link
Contributor

No description provided.

@irinascurtu irinascurtu requested a review from a team as a code owner February 17, 2025 10:07
Copy link

linux-foundation-easycla bot commented Feb 17, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@cartermp
Copy link
Contributor

@irinascurtu can you sign the CLA? They we can review.

@irinascurtu
Copy link
Contributor Author

@irinascurtu can you sign the CLA? They we can review.

Seems to be fine now

Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me overall, I would like @svrnm to weigh in on the type field.

@irinascurtu
Copy link
Contributor Author

Looks good to me overall, I would like @svrnm to weigh in on the type field.

I left only instrumentation there

@cartermp
Copy link
Contributor

/fix:all

@opentelemetrybot
Copy link
Collaborator

You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/13459162673

@cartermp
Copy link
Contributor

@irinascurtu to resolve the issues with registry validation, these are the errors:

Error: An author must have an email or a URL
Error: must match "else" schema
Error: must have required property 'name'
Error: must match "then" schema

@opentelemetrybot
Copy link
Collaborator

fix:all was successful.

IMPORTANT: (RE-)RUN /fix:all to ensure that there are no remaining check issues.

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comments, and please address validation failures.

@irinascurtu irinascurtu requested a review from chalin February 27, 2025 08:24
@irinascurtu
Copy link
Contributor Author

irinascurtu commented Feb 27, 2025

See inline comments, and please address validation failures.

@chalin
I don't understand what is wrong, I compared it to any other recent instrumentation-related PR that passed, and I don't understand what is wrong. The author is me, or the the company that created the library?

@chalin
Copy link
Contributor

chalin commented Mar 6, 2025

@svrnm - when you have a moment, could you help out here?

@svrnm
Copy link
Member

svrnm commented Mar 11, 2025

@svrnm - when you have a moment, could you help out here?

Commented on the issue, there is a dash that needs to be removed otherwise the url and name are treated as 2 different authros.

@irinascurtu apologies for the delay/slowness on my end, I am currently only able to provide limited availability

@irinascurtu irinascurtu requested a review from svrnm March 13, 2025 19:31
@chalin
Copy link
Contributor

chalin commented Mar 13, 2025

/fix:format

@opentelemetrybot
Copy link
Collaborator

You triggered fix:format action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/13844840417

@opentelemetrybot
Copy link
Collaborator

fix:format was successful.

IMPORTANT: (RE-)RUN /fix:all to ensure that there are no remaining check issues.

@irinascurtu
Copy link
Contributor Author

/fix:format

@opentelemetrybot
Copy link
Collaborator

You triggered fix:format action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/13893418453

@opentelemetrybot
Copy link
Collaborator

fix:format was successful.

IMPORTANT: (RE-)RUN /fix:all to ensure that there are no remaining check issues.

@chalin
Copy link
Contributor

chalin commented Mar 17, 2025

Waiting for @svrnm's final approval.

@irinascurtu
Copy link
Contributor Author

@chalin seems like @svrnm approved. We just need one more approval and then we can merge?

@chalin chalin enabled auto-merge March 20, 2025 14:03
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@chalin chalin disabled auto-merge March 20, 2025 14:04
@chalin chalin enabled auto-merge March 20, 2025 14:04
@chalin chalin added this pull request to the merge queue Mar 20, 2025
Merged via the queue into open-telemetry:main with commit edc10d6 Mar 20, 2025
19 checks passed
@opentelemetrybot
Copy link
Collaborator

Thank you for your contribution! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants