Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix confmap provider name #5683

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Conversation

jackgopack4
Copy link
Contributor

This changes the name for Collector Confmap Providers in the registry from "confmap provider" to "provider".

The way the registry shows how to add a component, confmap provider, is not the correct way to include a provider with your collector build. While the name is more descriptive, without knowing a way to have a different display name in the drop-down, it seems better to name it provider instead to ensure a correct code snippet.

Screenshot 2024-11-22 at 11 07 07 AM

@jackgopack4 jackgopack4 requested a review from a team as a code owner November 25, 2024 21:15
Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that's a good catch. I agree that it's much better to show the correct code sample than to have a slightly more descriptive name. Thanks.

@cartermp cartermp added this pull request to the merge queue Nov 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 26, 2024
@svrnm svrnm added this pull request to the merge queue Nov 27, 2024
Merged via the queue into open-telemetry:main with commit 41a2ea2 Nov 27, 2024
18 checks passed
ymotongpoo pushed a commit to ymotongpoo/opentelemetry.io that referenced this pull request Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants