feat: no search entries found page #5462
Conversation
svrnm
changed the title
|
@svrnm Thank you very much for the feedback. |
svrnm
changed the title
svrnm
changed the title
|
@JennySimen we are currently discussion #5681 to enable the import of the 3rd party image, after this being resolved we should be able to merge your PR |
|
Thank you, looking forward to having the pr merged. |
|
@JennySimen apologies for the delay and for going back and forth. I agree with @chalin's point in this comment (#5681 (comment)) that we should avoid adding the overhead of an image that needs attribution and a license reference in our code. It's much easier in docs/blog text since we simply can put a copy right notice below the image. I copy the relevant part of the discussion:
the font awesome icons might be too small/minimalistic, I like the idea of the image, of course someone with a telescope not finding what they are looking for would be my preferred image. We could also use a variant of https://opentelemetry.io/homepage-hero-as-background_hu13043826424429285166.jpg WDYT? |
|
@JennySimen any thoughts on my previous comment? |
|
Hi @svrnm, I think it's a great idea to use the above image instead. |
I saw that you requested my review, but nothing has changed, can you update the image as discussed? Thanks |
|
Hi @svrnm I have updated the image |
There was a problem hiding this comment.
This is what it looks like now. The base OTel background image maybe a good choice, but we shouldn't be using a Hugo-modified version of it (in particular this one is too dark).
You should do a resources.Get on the original image (or something like that -- I'll need to investigate further).
| if (results.length === 0) { | ||
| document.getElementById('no-search-result').style.display = 'block'; | ||
| } | ||
|
|
||
| populateResults(results); | ||
|
|
There was a problem hiding this comment.
This new code logic isn't correct. It breaks the responsiviness to form dropdown selection once a "no results" page has been viewed.
| <img style="border: none; margin-left: 40px;" src="{{ .RelPermalink }}" width="400" alt="no result found"> | ||
| {{ end }} | ||
| </div> | ||
| <p style="color: #4f62ad; font-size: 28px; margin-bottom: 0;">Oops no results found</p> |
There was a problem hiding this comment.
Nit: we shouldn't be hardcoding styles here.
I couldn't see that when I checked earlier today, now I do. See @chalin's feedback. It would also be great if the image is not black but aligns with the dark/light mode background, so you might need to edit that image, or we need to see if we can find a version with a light background |
|
@JennySimen - there are a few GitHub actions that are failing, such as: https://github.com/JennySimen/opentelemetry.io/actions/runs/13519263866 Could you refresh your fork, and disable those workflows? I keep getting failed workflow notifications from your fork. Thanks. /cc @trask |
chalin
changed the title
Hi @tedsuo, is there anything from my side needed to have the lighter backgorund artwork? |
Hi @chalin I have disabled the workflows as requested |
Let me ping @tedsuo @austinlparker et all on Slack to see if we can get response. |
|
The hero artwork was commissioned years ago, I forget by whom (or even if they have the originals any more -- IIRC I don't think I got a psd for it, just PNGs?) Looking at this thread, why not just use a FOSS icon library then scale up the icon? They are vector images after all. |
|
Actually found a way using CSS It would be great to not have to duplicate the image, and just use the CSS, but for starters, set it up with the image above. |
Closes #5372
This PR creates a new and better search result page when the is no seach found.
Steps to view work
Preview: https://deploy-preview-5462--opentelemetry.netlify.app/ecosystem/registry/?s=abcdef