Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

registry: Add Missing Rust Crates #4062

Merged
merged 4 commits into from
Feb 28, 2024

Conversation

hdost
Copy link
Contributor

@hdost hdost commented Feb 28, 2024

We recently cleaned up our README, and started referencing the Registry, but we want to make sure that the crates are still in the registry.

Relates open-telemetry/opentelemetry-rust#1582

Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is really great! Overall looks good to me

@hdost hdost force-pushed the feat/1582-add-missing-crates branch from 933539f to 5aded30 Compare February 28, 2024 08:13
We recently cleaned up our README, and started referencing the Registry,
but we want to make sure that the crates are still in the registry.

Relates open-telemetry/opentelemetry-rust#1582
@hdost hdost force-pushed the feat/1582-add-missing-crates branch from 5aded30 to 9be1982 Compare February 28, 2024 09:03
@svrnm
Copy link
Member

svrnm commented Feb 28, 2024

@hdost you can fix the format issue either by running npm run fix:format or comment /fix:format on this PR

@hdost hdost force-pushed the feat/1582-add-missing-crates branch from 0ed3c6c to e85a3e0 Compare February 28, 2024 09:32
@hdost
Copy link
Contributor Author

hdost commented Feb 28, 2024

@@ -9,8 +9,9 @@ license: Apache 2.0 OR MIT
description: A Rust OpenTelemetry exporter for Google StackDriver
authors:
- name: jacobkiesel
- name: OpenTelemetry Authors
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason why we still keep the prior author name?

Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@cartermp cartermp merged commit c0b5759 into open-telemetry:main Feb 28, 2024
14 checks passed
@hdost hdost deleted the feat/1582-add-missing-crates branch February 29, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants