automatically add traces / metrics paths

[GaryPWhite]

Resolves #773

[GaryPWhite]

noting that we could probably add logs exporter -- I noticed there was documentation for log signals, but the logs.rs exporter doesn't exist :)

[TommyCpp]

noting that we could probably add logs exporter -- I noticed there was documentation for log signals, but the logs.rs exporter doesn't exist :)

Ahh yeah once we merged #788 we can implement a logs exporter

[codecov]

Codecov Report

Merging #806 (ed5eae5) into main (1f84f4a) will increase coverage by 0.0%.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main    #806   +/-   ##
=====================================
  Coverage   69.7%   69.8%           
=====================================
  Files        110     110           
  Lines       9061    9072   +11     
=====================================
+ Hits        6324    6334   +10     
- Misses      2737    2738    +1     

Impacted Files	Coverage Δ
opentelemetry-otlp/src/span.rs	0.0% <ø> (ø)
opentelemetry-datadog/src/exporter/model/v03.rs	85.4% <0.0%> (-1.6%)	⬇️
opentelemetry-datadog/src/exporter/model/v05.rs	82.3% <0.0%> (-1.6%)	⬇️
opentelemetry-sdk/src/trace/span_processor.rs	79.7% <0.0%> (-0.1%)	⬇️
opentelemetry-http/src/lib.rs	12.2% <0.0%> (ø)
opentelemetry-jaeger/src/lib.rs	93.0% <0.0%> (ø)
opentelemetry-sdk/src/runtime.rs	69.7% <0.0%> (ø)
opentelemetry-datadog/src/exporter/model/mod.rs	77.3% <0.0%> (ø)
opentelemetry-sdk/src/trace/runtime.rs	15.7% <0.0%> (+0.3%)	⬆️
... and 1 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f84f4a...ed5eae5. Read the comment docs.

[TommyCpp]

I think it generally looks good. Thanks! The CI failure seems to be caused by unformatted code. Running cargo fmt should fix it.

One ask I have is maybe we can add some document to explain the relationship between OTEL_EXPORTER_OTLP_END and OTEL_EXPORTER_OTLP_{signal}_ENDPOINT like https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/protocol/exporter.md#endpoint-urls-for-otlphttp.

And reference it from env var constants. It may be easier for user to understand what to choose

[GaryPWhite]

added links to the spec from those constants -- hope that helps!

[GaryPWhite]

noting that we could probably add logs exporter -- I noticed there was documentation for log signals, but the logs.rs exporter doesn't exist :)

Ahh yeah once we merged #788 we can implement a logs exporter

I can make an issue or continue from #773 when it is merged! feel free to assign me or let me know here!

[TommyCpp]

It seems log may need sometime to land. I think we can close #773 and create a new one for add log path and related envionment variables.

The change looks nice 👍

[jtescher]

Just waiting on tests/lints now?

[GaryPWhite]

sorry about that -- doesn't run without maintainers clicking it so the feedback loop is long :)

[TommyCpp]

sorry about that -- doesn't run without maintainers clicking it so the feedback loop is long :)

It only applies to the first PR(to prevent bad actors from injecting crypto code in PR to exploit CI pipeline). Should be better once it's merged

[TommyCpp]

Running ./precommit.sh can help find the lint issue

[GaryPWhite]

alright let me run that and be back in a sec

[TommyCpp]

Emm looks like the EasyCLA stuck again 😞

[GaryPWhite]

no worries. I'll find something to fix i'm sure with the script and push a new one up

[GaryPWhite]

nice! looks like it went through 💯 Thanks for the help :)