Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: small perf improvements in OTel API #2842

Merged
merged 3 commits into from
Mar 22, 2025

Conversation

gruebel
Copy link
Member

@gruebel gruebel commented Mar 21, 2025

Changes

  • mostly removed redundant cloning

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@gruebel gruebel requested a review from a team as a code owner March 21, 2025 18:10
Copy link

codecov bot commented Mar 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.8%. Comparing base (d32d34c) to head (c1fe2da).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2842   +/-   ##
=====================================
  Coverage   80.8%   80.8%           
=====================================
  Files        124     124           
  Lines      23682   23682           
=====================================
+ Hits       19137   19138    +1     
+ Misses      4545    4544    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice/

Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I want to avoid merging PRs unless necessary on the day of release. Will merge right after I finish 0.29 release.
Requesting changes to prevent accidental merge today.

@cijothomas cijothomas self-requested a review March 22, 2025 00:45
@cijothomas cijothomas dismissed their stale review March 22, 2025 00:46

0.29 release done and all PRs are now unblocked

@cijothomas cijothomas merged commit c5d5a1c into open-telemetry:main Mar 22, 2025
23 checks passed
@gruebel gruebel deleted the perf-improve branch March 22, 2025 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants