test: validate code-based config is preferred over env vars in ZipkinExporterBuilder #2836
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2836 +/- ##
=======================================
+ Coverage 80.5% 80.7% +0.1%
=======================================
Files 124 124
Lines 23477 23493 +16
=======================================
+ Hits 18914 18961 +47
+ Misses 4563 4532 -31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| @@ -93,6 +93,9 @@ impl ZipkinExporterBuilder { | |||
| } | |||
|
|
|||
| /// Assign client implementation | |||
| /// | |||
| /// Note: Programmatically setting the timeout will override any value | |||
| /// set via the environment variable `OTEL_EXPORTER_ZIPKIN_TIMEOUT`. | |||
There was a problem hiding this comment.
this comment is for timeout, but this method is for setting client?
There was a problem hiding this comment.
correct, you can only set the timeout manually, if you create a client, because the timeout is used during the client creation.
There was a problem hiding this comment.
can you modify the comment to make it clearer?
when using with_http_client, the timeout will depend on the provided client implementation, and may not respect timeout set via the environment variable OTEL_EXPORTER_ZIPKIN_TIMEOUT.
Relates to #1225
Changes
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes