Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix filter for benchmark pushes on branch #2834

Merged
merged 6 commits into from
Mar 19, 2025

Conversation

scottgerring
Copy link
Contributor

@scottgerring scottgerring commented Mar 19, 2025

Changes

Something wasn't quite write with the filter for the branch runs; simplifying it into a single line seems to do the trick.
Have tested with and without label and validated it fires and doesn't fire accordingly.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@scottgerring scottgerring changed the title CI: filter pull events for benchmark on push to only run for main ci: filter pull events for benchmark on push to only run for main Mar 19, 2025
@scottgerring scottgerring reopened this Mar 19, 2025
@scottgerring scottgerring reopened this Mar 19, 2025
@scottgerring scottgerring changed the title ci: filter pull events for benchmark on push to only run for main ci: fix filter for benchmark pushes on branch Mar 19, 2025
@scottgerring
Copy link
Contributor Author

@cijothomas sorry about that! The previous PR seems to trigger for branches regardless of label. This slight reformatting of the condition into a single line addresses that.

@scottgerring scottgerring marked this pull request as ready for review March 19, 2025 15:15
@scottgerring scottgerring requested a review from a team as a code owner March 19, 2025 15:15
Copy link

codecov bot commented Mar 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.4%. Comparing base (5be79c7) to head (f09bbc4).
Report is 2 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2834   +/-   ##
=====================================
  Coverage   80.4%   80.4%           
=====================================
  Files        124     124           
  Lines      23390   23390           
=====================================
+ Hits       18824   18828    +4     
+ Misses      4566    4562    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cijothomas cijothomas merged commit 31b494b into open-telemetry:main Mar 19, 2025
37 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants