Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add warning on Prometheus crate #2831

Merged
merged 9 commits into from
Mar 20, 2025

Conversation

cijothomas
Copy link
Member

Fixes #2451
As discussed in the community call, updating OTLP doc to show prometheus integration, and add warning to prometheus doc about discontinuation.

We can do 0.29 release and end it.

@cijothomas cijothomas requested a review from a team as a code owner March 19, 2025 04:52
Copy link

codecov bot commented Mar 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.7%. Comparing base (969bedf) to head (c6d30a6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2831   +/-   ##
=====================================
  Coverage   80.7%   80.7%           
=====================================
  Files        124     124           
  Lines      23490   23490           
=====================================
  Hits       18961   18961           
  Misses      4529    4529           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lalitb
Copy link
Member

lalitb commented Mar 19, 2025

Should we also mark it as deprecated in Cargo.toml as done by async-std -
https://github.com/async-rs/async-std/blob/96f564672a8588ac0516e86580c249009ad3e94f/Cargo.toml#L15

@cijothomas
Copy link
Member Author

@scottgerring It looks like the benchmark action is triggered for this, even though the GitHub label is not added and this is not main!

@cijothomas cijothomas merged commit b03296c into open-telemetry:main Mar 20, 2025
22 of 23 checks passed
@cijothomas cijothomas deleted the cijothomas/prom-warning branch March 20, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discontinue prometheus crate?
3 participants