Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix span_processor test failing with default features #2782

Conversation

paullegranddc
Copy link
Contributor

Some of the assertions are only passing if experimental_trace_batch_span_processor_with_async_runtime is enabled, which is not in the default features set, so running cargo test --workspace without specifying features is failing.

Changes

  • Add a feature gate around failing assertions

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@paullegranddc paullegranddc requested a review from a team as a code owner March 11, 2025 13:14
Copy link

linux-foundation-easycla bot commented Mar 11, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link

codecov bot commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.7%. Comparing base (68c9133) to head (914721e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2782   +/-   ##
=====================================
  Coverage   79.7%   79.7%           
=====================================
  Files        123     123           
  Lines      23115   23117    +2     
=====================================
+ Hits       18426   18428    +2     
  Misses      4689    4689           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cijothomas cijothomas merged commit dac8bd5 into open-telemetry:main Mar 11, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants