Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add test to confirm programmatic config wins over env in BatchConfig #2781

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

cijothomas
Copy link
Member

Part of #1225
For BatchLogProcessor, we were already preferring code over env_variables, so there is no change required. I added tests to confirm the behavior, and included this information in the docs too.

This is just the start, we need to audit entire ENV variables in the repo, and make changes.

@cijothomas cijothomas requested a review from a team as a code owner March 11, 2025 02:19
@cijothomas cijothomas changed the title Add test to confirm programmatic config wins over env in BatchConfig test: Add test to confirm programmatic config wins over env in BatchConfig Mar 11, 2025
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.7%. Comparing base (51dda2f) to head (5773fc9).

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2781   +/-   ##
=====================================
  Coverage   79.7%   79.7%           
=====================================
  Files        123     123           
  Lines      23117   23136   +19     
=====================================
+ Hits       18428   18447   +19     
  Misses      4689    4689           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the test. Similar to be added for Span Processor too. LGTM once this is fixed - https://github.com/open-telemetry/opentelemetry-rust/pull/2781/files#r1989799553

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants