chore: Move FutureExt into context #2776
Draft
+122
−118
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2754
Changes
opentelemetry::context
fromcontext.rs
tocontext/mod.rs
module style so that we can addfuture_ext
without jamming everything together into the same fileFutureExt
fromopentelemetry::trace::context
intoopentelemetry::context::future_ext
FutureExt
in trace to maintain backwards compatibilityI had to make a couple bits in
Context
pub(crate)
to make this work.I'm not sure what to call the file containing
Context
-opentelemetry/src/context/context_store.rs
- its contents are re-exported ascontext::Context
as previously available, but double nesting the same module name is a bad practice, and so is putting anything inmod.rs
itself. An alternate would be to leave the existing code insrc/context.rs
, and then use the newer module format to add the new bits within the same module insrc/context/future_ext.rs
.Open to suggestions!
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes