Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: AtomicI64, AtomicU64 for xtensa arch #2773

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

brunobrolesi
Copy link

@brunobrolesi brunobrolesi commented Mar 8, 2025

Fixes #

I'm working on a personal project that tries to add observability to an mqtt system with ESP32 microcontrollers. When I tried to use the open telemetry crate to export my program's traces, I encountered the following build error:

image

Changes

After doing some analysis on the subject, I came across the following PR that had the same problem, but for other architectures. Based on the discussion of the PR, I made the changes for the architecture I am using and was able to use the stdout exporter, as can be seen in the image below:

image

One thing to note, this change only allowed me to use the stout exporter, the others had problems due to a compilation error related to the dependencies hyper and socket 2, this problem can be seen in the issues below:

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@brunobrolesi brunobrolesi requested a review from a team as a code owner March 8, 2025 23:28
Copy link

linux-foundation-easycla bot commented Mar 8, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link

codecov bot commented Mar 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.7%. Comparing base (68c9133) to head (e69b763).

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2773   +/-   ##
=====================================
  Coverage   79.7%   79.7%           
=====================================
  Files        123     123           
  Lines      23115   23115           
=====================================
+ Hits       18426   18427    +1     
+ Misses      4689    4688    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cijothomas
Copy link
Member

@brunobrolesi Thanks! Can you check if this is only place where Atomics were used? It's okay to do it in a follow up, if you are okay with that. (Trying to make sure we do support extra architectures consistently across repo (wherever feasible))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants