-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: refactor Baggage with Context interaction #2748
refactor: refactor Baggage with Context interaction #2748
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2748 +/- ##
=====================================
Coverage 79.6% 79.6%
=====================================
Files 123 123
Lines 23041 23034 -7
=====================================
Hits 18356 18356
+ Misses 4685 4678 -7 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with nit comment here.
# Conflicts: # opentelemetry/CHANGELOG.md
Relates to #2717 point 6
Changes
with_baggage()
andcurrent_with_baggage()
now only accept aBaggage
instance and override any existingBaggage
in theContext
BaggageContextValue
to hide the direct retrieval ofBaggage
fromContext
to make sure it needs to accessed viacontext.baggage()
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes