Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add test to show how to add baggage to logrecords via processor #2738

Merged

Conversation

cijothomas
Copy link
Member

Similar to #2732
This exposes another inconsistency across logs and traces - SpanProcessor has explicit Context, but LogProcessor do not. This PR is not attempting to change that, that'll be discussed separately.

@cijothomas cijothomas requested a review from a team as a code owner March 2, 2025 18:01
Copy link

codecov bot commented Mar 2, 2025

Codecov Report

Attention: Patch coverage is 93.75000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 79.5%. Comparing base (f15a337) to head (2f72359).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
opentelemetry-sdk/src/logs/mod.rs 93.7% 3 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2738   +/-   ##
=====================================
  Coverage   79.5%   79.5%           
=====================================
  Files        123     123           
  Lines      22831   22879   +48     
=====================================
+ Hits       18156   18201   +45     
- Misses      4675    4678    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cijothomas cijothomas merged commit 88cae2c into open-telemetry:main Mar 4, 2025
23 checks passed
@cijothomas cijothomas deleted the cijothomas/log-baggage-test branch March 4, 2025 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants