Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix Logger scope in Tracing Appender #2735

Conversation

cijothomas
Copy link
Member

Fixes #2658

@cijothomas cijothomas requested a review from a team as a code owner March 1, 2025 20:46
Copy link

codecov bot commented Mar 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.5%. Comparing base (5a77fb2) to head (ba1da15).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2735   +/-   ##
=====================================
  Coverage   79.4%   79.5%           
=====================================
  Files        123     123           
  Lines      22781   22831   +50     
=====================================
+ Hits       18107   18157   +50     
  Misses      4674    4674           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cijothomas cijothomas changed the title Fix Logger scope in Tracing Appender fix: Fix Logger scope in Tracing Appender Mar 2, 2025
Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Nit -

@cijothomas
Copy link
Member Author

LGTM.

Nit -

Yes. Opened #2747 to track

@cijothomas cijothomas merged commit f15a337 into open-telemetry:main Mar 4, 2025
23 checks passed
@cijothomas cijothomas deleted the cijothomas/appender-tracing-fix-scope branch March 4, 2025 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Appender-Tracing - handle target and scope
2 participants