-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix Logger scope in Tracing Appender #2735
fix: Fix Logger scope in Tracing Appender #2735
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2735 +/- ##
=====================================
Coverage 79.4% 79.5%
=====================================
Files 123 123
Lines 22781 22831 +50
=====================================
+ Hits 18107 18157 +50
Misses 4674 4674 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Nit -
- Similar changes for log appender
let scope = InstrumentationScope::builder("opentelemetry-log-appender") - this can be possibly cleanup too -
let (library, target) = data;
Yes. Opened #2747 to track |
Fixes #2658