Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: align baggage.remove() implementation #2734

Merged
merged 5 commits into from
Mar 3, 2025

Conversation

gruebel
Copy link
Member

@gruebel gruebel commented Mar 1, 2025

Relates to #2717 point 6

Changes

  • also added a simple CRUD test to make sure, all the operations work as intended (also the conflict override)

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@gruebel gruebel requested a review from a team as a code owner March 1, 2025 19:25
Copy link

codecov bot commented Mar 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.4%. Comparing base (46a7cd6) to head (b1a96da).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2734   +/-   ##
=====================================
  Coverage   79.4%   79.4%           
=====================================
  Files        123     123           
  Lines      22770   22781   +11     
=====================================
+ Hits       18088   18106   +18     
+ Misses      4682    4675    -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
(Merged other PR so need to resolve conflict before merge.)

gruebel added 4 commits March 1, 2025 21:22
# Conflicts:
#	opentelemetry/src/baggage.rs
# Conflicts:
#	opentelemetry/CHANGELOG.md
#	opentelemetry/src/baggage.rs
@cijothomas cijothomas merged commit 2493fec into open-telemetry:main Mar 3, 2025
23 checks passed
@gruebel gruebel deleted the fix-baggage-rm branch March 3, 2025 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants