Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Try fix a flaky test #2719

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

cijothomas
Copy link
Member

Occasionally seeing this failing in CI. I suspect it maybe capturing OTel's own logs. A quick fix is to filter for Error and above, so OTel Logs are unlikely to be captured. A more robust fix might be needed in the future, but this should unblock hopefully!

---- layer::tests::tracing_appender_inside_tracing_crate_context stdout ----

thread 'layer::tests::tracing_appender_inside_tracing_crate_context' panicked at opentelemetry-appender-tracing/src/layer.rs:550:9:
assertion left == right failed
left: 3
right: 2
note: run with RUST_BACKTRACE=1 environment variable to display a backtrace

@cijothomas cijothomas requested a review from a team as a code owner February 26, 2025 17:18
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.3%. Comparing base (4830a3c) to head (38ed411).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2719   +/-   ##
=====================================
  Coverage   79.3%   79.3%           
=====================================
  Files        123     123           
  Lines      22670   22670           
=====================================
  Hits       17986   17986           
  Misses      4684    4684           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lalitb
Copy link
Member

lalitb commented Feb 26, 2025

I suspect it maybe capturing OTel's own logs.

Yes, I also suspected that. But I don't understand why it is not consistent.

@cijothomas cijothomas merged commit 08a1f52 into open-telemetry:main Feb 26, 2025
23 checks passed
@cijothomas cijothomas deleted the cijothomas/flakytestfix1 branch February 26, 2025 18:05
@cijothomas
Copy link
Member Author

I suspect it maybe capturing OTel's own logs.

Yes, I also suspected that. But I don't understand why it is not consistent.

next time it fails, we'll have the LogRecord in console logs. That should give some hint. (or this fix works and we never see failure again 🤣 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants