Doc additions to warn about tokio current #2594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2594 +/- ##
=====================================
Coverage 79.3% 79.3%
=====================================
Files 118 118
Lines 22478 22478
=====================================
Hits 17835 17835
Misses 4643 4643 ☔ View full report in Codecov by Sentry. |
lalitb
approved these changes
Feb 3, 2025
| /// **Warning**: When using tokio's current-thread runtime, `shutdown()`, which | ||
| /// is a blocking call ,should not be called from your main thread. This can | ||
| /// cause deadlock. Instead, call `shutdown()` from a separate thread or use | ||
| /// tokio's `spawn_blocking`. |
There was a problem hiding this comment.
This is valid for force_flush() too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2583
and few doc improvements.