Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove export timeout configuration for BatchLogProcessor. #2587

Merged

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented Feb 3, 2025

Fixes: towards #2576

Changes

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@lalitb lalitb requested a review from a team as a code owner February 3, 2025 08:08
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.5%. Comparing base (dde68a0) to head (7dd1330).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #2587     +/-   ##
=======================================
- Coverage   79.5%   79.5%   -0.1%     
=======================================
  Files        118     118             
  Lines      22480   22476      -4     
=======================================
- Hits       17878   17874      -4     
  Misses      4602    4602             

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you planning to do the same for Span and PeriodicReader too?

PeriodicReader may need some discussion... As Observables are called during collect, so pushing timeout entirely to Exporter is not the best option. Unfortunately that is probably our only option too, so maybe we can cover it via good doc.

@lalitb
Copy link
Member Author

lalitb commented Feb 3, 2025

Are you planning to do the same for Span and PeriodicReader too?
PeriodicReader may need some discussion... As Observables are called during collect, so pushing timeout entirely to Exporter is not the best option. Unfortunately that is probably our only option too, so maybe we can cover it via good doc.

Yes, will raise the PR for both. We can discuss the Observables issue over the PR.

@cijothomas cijothomas merged commit 7c9447f into open-telemetry:main Feb 3, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants