Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics aggregate collector generic over temporality #2506

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Address review comments #1

ea151e4
Select commit
Loading
Failed to load commit list.
Open

Metrics aggregate collector generic over temporality #2506

Address review comments #1
ea151e4
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 21, 2025 in 0s

77.9% (+0.0%) compared to 68af3bb

View this Pull Request on Codecov

77.9% (+0.0%) compared to 68af3bb

Details

Codecov Report

Attention: Patch coverage is 95.97701% with 7 lines in your changes missing coverage. Please review.

Project coverage is 77.9%. Comparing base (68af3bb) to head (ea151e4).

Files with missing lines Patch % Lines
...-sdk/src/metrics/internal/exponential_histogram.rs 91.1% 6 Missing ⚠️
...pentelemetry-sdk/src/metrics/internal/collector.rs 98.7% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2506   +/-   ##
=====================================
  Coverage   77.9%   77.9%           
=====================================
  Files        123     124    +1     
  Lines      22944   22974   +30     
=====================================
+ Hits       17880   17915   +35     
+ Misses      5064    5059    -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.