Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate logger::provider() and logger::instrumentation_scope() #2349

Merged
merged 8 commits into from
Nov 26, 2024

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented Nov 26, 2024

Changes

Deprecating these methods. The methods were meant to be used by appenders, and they can always keep hold to the provider handle to get this data. We can anyway have additive changes even after stable release, so safe to remove it for now. Thanks for noticing them @utpilla :)

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@lalitb lalitb requested a review from a team as a code owner November 26, 2024 18:58
lalitb and others added 2 commits November 26, 2024 11:13
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.5%. Comparing base (c9388e4) to head (bceded9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #2349     +/-   ##
=======================================
- Coverage   79.5%   79.5%   -0.1%     
=======================================
  Files        123     123             
  Lines      21371   21366      -5     
=======================================
- Hits       17006   17000      -6     
- Misses      4365    4366      +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cijothomas cijothomas merged commit 91370d2 into open-telemetry:main Nov 26, 2024
22 of 23 checks passed
pitoniak32 pushed a commit to pitoniak32/opentelemetry-rust that referenced this pull request Dec 4, 2024
@lalitb lalitb mentioned this pull request Dec 8, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants