Global error handler cleanup - Metrics data-point overflow #2259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utpilla
approved these changes
Oct 28, 2024
cijothomas
reviewed
Oct 29, 2024
| @@ -146,7 +145,6 @@ impl<AU: AtomicallyUpdate<T>, T: Number, O: Operation> ValueMap<AU, T, O> { | |||
| let new_tracker = AU::new_atomic_tracker(self.buckets_count); | |||
| O::update_tracker(&new_tracker, measurement, index); | |||
| trackers.insert(STREAM_OVERFLOW_ATTRIBUTES.clone(), Arc::new(new_tracker)); | |||
| global::handle_error(MetricError::Other("Warning: Maximum data points for metric stream exceeded. Entry added to overflow. Subsequent overflows to same metric until next collect will not be logged.".into())); | |||
| otel_warn!( name: "ValueMap.measure", | |||
There was a problem hiding this comment.
the name "ValueMap.measure" is not meaningful for end users.
cijothomas
approved these changes
Oct 29, 2024
There was a problem hiding this comment.
https://github.com/open-telemetry/opentelemetry-rust/pull/2259/files#r1820058916 can be separatelly addressed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2259 +/- ##
=======================================
- Coverage 79.4% 79.4% -0.1%
=======================================
Files 121 121
Lines 20962 20961 -1
=======================================
- Hits 16656 16648 -8
- Misses 4306 4313 +7 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Design discussion issue (if applicable) #
Changes
Please provide a brief description of the changes here.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes