Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid redundant shutdown in LoggerProvider::drop when already shut down #2195

Merged
merged 15 commits into from
Oct 12, 2024

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented Oct 11, 2024

Changes

Prevents LoggerProvider::drop from calling shutdown if the provider has already been shut down.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@lalitb lalitb requested a review from a team as a code owner October 11, 2024 17:33
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 87.85047% with 13 lines in your changes missing coverage. Please review.

Project coverage is 79.2%. Comparing base (20fd454) to head (637d3da).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
opentelemetry-sdk/src/logs/log_emitter.rs 87.8% 13 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #2195   +/-   ##
=====================================
  Coverage   79.2%   79.2%           
=====================================
  Files        121     121           
  Lines      20870   20964   +94     
=====================================
+ Hits       16532   16620   +88     
- Misses      4338    4344    +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some comment left here:
https://github.com/open-telemetry/opentelemetry-rust/pull/2195/files#r1797268610

Please check if it makes sense. I am not I understand the reasoning fully why LoggerProvider is doing things differently than MeterProvider..

@cijothomas cijothomas merged commit b6a108e into open-telemetry:main Oct 12, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants