-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid redundant shutdown in LoggerProvider::drop when already shut down #2195
Avoid redundant shutdown in LoggerProvider::drop when already shut down #2195
Conversation
…telemetry-rust into logmanager-prevernt-shutdown
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2195 +/- ##
=====================================
Coverage 79.2% 79.2%
=====================================
Files 121 121
Lines 20870 20964 +94
=====================================
+ Hits 16532 16620 +88
- Misses 4338 4344 +6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some comment left here:
https://github.com/open-telemetry/opentelemetry-rust/pull/2195/files#r1797268610
Please check if it makes sense. I am not I understand the reasoning fully why LoggerProvider is doing things differently than MeterProvider..
Changes
Prevents LoggerProvider::drop from calling shutdown if the provider has already been shut down.
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes