Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global error handler cleanup - Metrics SDK #2185

Closed
wants to merge 24 commits into from
+204 −96

add comment for exponential histogram

115e73f
Select commit
Loading
Failed to load commit list.
Closed

Global error handler cleanup - Metrics SDK #2185

add comment for exponential histogram
115e73f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 23, 2024 in 1s

78.9% (-0.3%) compared to 8bd529a

View this Pull Request on Codecov

78.9% (-0.3%) compared to 8bd529a

Details

Codecov Report

Attention: Patch coverage is 15.74074% with 91 lines in your changes missing coverage. Please review.

Project coverage is 78.9%. Comparing base (8bd529a) to head (115e73f).

Files with missing lines Patch % Lines
opentelemetry-sdk/src/metrics/meter.rs 21.2% 52 Missing ⚠️
opentelemetry-sdk/src/metrics/pipeline.rs 0.0% 12 Missing ⚠️
opentelemetry-sdk/src/metrics/view.rs 8.3% 11 Missing ⚠️
...-sdk/src/metrics/internal/exponential_histogram.rs 0.0% 9 Missing ⚠️
...pentelemetry-sdk/src/metrics/internal/aggregate.rs 0.0% 3 Missing ⚠️
opentelemetry-sdk/src/metrics/internal/mod.rs 50.0% 2 Missing ⚠️
opentelemetry-sdk/src/metrics/manual_reader.rs 0.0% 1 Missing ⚠️
opentelemetry-sdk/src/metrics/meter_provider.rs 0.0% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##            main   #2185     +/-   ##
=======================================
- Coverage   79.1%   78.9%   -0.3%     
=======================================
  Files        121     121             
  Lines      21171   21220     +49     
=======================================
- Hits       16760   16751      -9     
- Misses      4411    4469     +58

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov