Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global error handler cleanup - Metrics SDK #2185

Closed
wants to merge 24 commits into from

remove formatting in wrapper macros

3aa97cf
Select commit
Loading
Failed to load commit list.
Closed

Global error handler cleanup - Metrics SDK #2185

remove formatting in wrapper macros
3aa97cf
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 10, 2024 in 0s

79.1% (-0.1%) compared to af4527c

View this Pull Request on Codecov

79.1% (-0.1%) compared to af4527c

Details

Codecov Report

Attention: Patch coverage is 18.86792% with 43 lines in your changes missing coverage. Please review.

Project coverage is 79.1%. Comparing base (af4527c) to head (3aa97cf).

Files with missing lines Patch % Lines
opentelemetry-sdk/src/metrics/pipeline.rs 0.0% 11 Missing ⚠️
opentelemetry-sdk/src/metrics/view.rs 8.3% 11 Missing ⚠️
...-sdk/src/metrics/internal/exponential_histogram.rs 0.0% 7 Missing ⚠️
opentelemetry-sdk/src/metrics/meter.rs 50.0% 7 Missing ⚠️
...pentelemetry-sdk/src/metrics/internal/aggregate.rs 0.0% 3 Missing ⚠️
opentelemetry-sdk/src/metrics/internal/mod.rs 50.0% 2 Missing ⚠️
opentelemetry-sdk/src/metrics/manual_reader.rs 0.0% 1 Missing ⚠️
opentelemetry-sdk/src/metrics/meter_provider.rs 0.0% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##            main   #2185     +/-   ##
=======================================
- Coverage   79.1%   79.1%   -0.1%     
=======================================
  Files        121     121             
  Lines      20879   20891     +12     
=======================================
- Hits       16534   16528      -6     
- Misses      4345    4363     +18

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov