Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global error handler cleanup - Metrics SDK #2185

Closed
wants to merge 24 commits into from

change name for exponential histogram

b8cb6af
Select commit
Loading
Failed to load commit list.
Closed

Global error handler cleanup - Metrics SDK #2185

change name for exponential histogram
b8cb6af
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 9, 2024 in 0s

79.0% (+0.0%) compared to 720c62d

View this Pull Request on Codecov

79.0% (+0.0%) compared to 720c62d

Details

Codecov Report

Attention: Patch coverage is 23.40426% with 36 lines in your changes missing coverage. Please review.

Project coverage is 79.0%. Comparing base (720c62d) to head (b8cb6af).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...-sdk/src/metrics/internal/exponential_histogram.rs 0.0% 9 Missing ⚠️
opentelemetry-sdk/src/metrics/meter.rs 50.0% 7 Missing ⚠️
opentelemetry-sdk/src/metrics/periodic_reader.rs 25.0% 6 Missing ⚠️
opentelemetry-sdk/src/metrics/pipeline.rs 0.0% 6 Missing ⚠️
opentelemetry-sdk/src/metrics/view.rs 16.6% 5 Missing ⚠️
opentelemetry-sdk/src/metrics/internal/mod.rs 50.0% 1 Missing ⚠️
opentelemetry-sdk/src/metrics/manual_reader.rs 0.0% 1 Missing ⚠️
opentelemetry-sdk/src/metrics/meter_provider.rs 0.0% 1 Missing ⚠️
Additional details and impacted files 
@@          Coverage Diff          @@
##            main   #2185   +/-   ##
=====================================
  Coverage   79.0%   79.0%           
=====================================
  Files        121     121           
  Lines      20945   20883   -62     
=====================================
- Hits       16561   16515   -46     
+ Misses      4384    4368   -16

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov