Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metrics API] [Breaking] Enforce meter name, version schema_url to be static string slices #2112

Merged
merged 8 commits into from
Sep 17, 2024
+27 −116

Merge branch 'main' into utpilla/Remove-ObjectSafeMeterProvider

ed06697
Select commit
Loading
Failed to load commit list.
Merged

[Metrics API] [Breaking] Enforce meter name, version schema_url to be static string slices #2112

Merge branch 'main' into utpilla/Remove-ObjectSafeMeterProvider
ed06697
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Sep 12, 2024 in 0s

88.4% of diff hit (target 78.3%)

View this Pull Request on Codecov

88.4% of diff hit (target 78.3%)

Annotations

Check warning on line 543 in opentelemetry-sdk/src/metrics/meter.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

opentelemetry-sdk/src/metrics/meter.rs#L543 

Added line #L543 was not covered by tests

Check warning on line 717 in opentelemetry-sdk/src/metrics/mod.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

opentelemetry-sdk/src/metrics/mod.rs#L717 

Added line #L717 was not covered by tests

Check warning on line 74 in opentelemetry/src/global/metrics.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

opentelemetry/src/global/metrics.rs#L72-L74 

Added lines #L72 - L74 were not covered by tests

Check warning on line 33 in opentelemetry/src/metrics/noop.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

opentelemetry/src/metrics/noop.rs#L31-L33 

Added lines #L31 - L33 were not covered by tests
View more details on Codecov