Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use event.name as attribute key for exporting Log event name #2050

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

cijothomas
Copy link
Member

This is still being discussed in Event SIG and semantic conventions, but I propose to name it "event.name" before the upcoming release. There is high chance that "event.name" will be the final name, so we can avoid yet another breaking change after the coming release.
This is still under feature-flag.

(Similar change for stdout exporter is needed, but that'll be done the current refactoring of stdout exporter to avoid conflicts)

@cijothomas cijothomas requested a review from a team August 23, 2024 21:24
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.3%. Comparing base (b24bb9c) to head (9ec7986).
Report is 1 commits behind head on main.

Files Patch % Lines
opentelemetry-proto/src/transform/logs.rs 0.0% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #2050     +/-   ##
=======================================
- Coverage   77.3%   77.3%   -0.1%     
=======================================
  Files        124     124             
  Lines      21282   21282             
=======================================
- Hits       16472   16471      -1     
- Misses      4810    4811      +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cijothomas cijothomas merged commit 322c985 into open-telemetry:main Aug 26, 2024
24 of 25 checks passed
@cijothomas cijothomas deleted the cijothomas/eventname branch August 26, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants