Move ValueMap to mod file to allow for code reuse #2012
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #2004, we can potentially reuse
ValueMap
to track the measurements for any instrument.ValueMap
offers a more performant tracking mechanism:ValueMap
's update logic would also help avoid unnecessary allocation ofAttributeSet
on the hot-path)Currently, only counters (
Sum
aggreagtion) make use ofValueMap
.Changes
ValueMap
tomod.rs
(a common place from where other instruments can also use it)Next
ValueMap
forGauge
.