Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update semantic convention version v1.27.0 #2000

Merged
merged 6 commits into from
Aug 8, 2024

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented Aug 7, 2024

Changes

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@lalitb lalitb requested a review from a team August 7, 2024 23:26
@@ -35,7 +35,7 @@ docker run --rm \
-v "${CRATE_DIR}/scripts/templates:/templates" \
-v "${CRATE_DIR}/src:/output" \
otel/semconvgen:$SEMCOVGEN_VERSION \
--only span,event,scope \
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scope type is removed from latest build-tool, and is unused - open-telemetry/build-tools#309

@lalitb
Copy link
Member Author

lalitb commented Aug 7, 2024

Moving to draft to fix the build error

@lalitb lalitb marked this pull request as draft August 7, 2024 23:40
@@ -14,7 +14,9 @@
{%- set attribute = (attrs | selectattr('deprecated', 'none') | first) %}
{%- set attribute = attribute if attribute else (attrs | first) %}
{%- if conventions != 'attribute' %}
{%- if not attribute.deprecated %}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conditional check to ensure that the deprecated constants only defined with #[deprecated] annotation, and not exported.

@lalitb lalitb marked this pull request as ready for review August 8, 2024 00:44
@lalitb
Copy link
Member Author

lalitb commented Aug 8, 2024

Moving to draft to fix the build error

should be good now.

Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.1%. Comparing base (2409c18) to head (bb11b14).

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #2000     +/-   ##
=======================================
- Coverage   75.1%   75.1%   -0.1%     
=======================================
  Files        122     122             
  Lines      20642   20642             
=======================================
- Hits       15506   15505      -1     
- Misses      5136    5137      +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cijothomas cijothomas merged commit e905cf7 into open-telemetry:main Aug 8, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants