-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update semantic convention version v1.27.0 #2000
Conversation
@@ -35,7 +35,7 @@ docker run --rm \ | |||
-v "${CRATE_DIR}/scripts/templates:/templates" \ | |||
-v "${CRATE_DIR}/src:/output" \ | |||
otel/semconvgen:$SEMCOVGEN_VERSION \ | |||
--only span,event,scope \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
scope
type is removed from latest build-tool, and is unused - open-telemetry/build-tools#309
…st into sem-conv-v1.27.0
Moving to draft to fix the build error |
@@ -14,7 +14,9 @@ | |||
{%- set attribute = (attrs | selectattr('deprecated', 'none') | first) %} | |||
{%- set attribute = attribute if attribute else (attrs | first) %} | |||
{%- if conventions != 'attribute' %} | |||
{%- if not attribute.deprecated %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
conditional check to ensure that the deprecated constants only defined with #[deprecated]
annotation, and not exported.
should be good now. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2000 +/- ##
=======================================
- Coverage 75.1% 75.1% -0.1%
=======================================
Files 122 122
Lines 20642 20642
=======================================
- Hits 15506 15505 -1
- Misses 5136 5137 +1 ☔ View full report in Codecov by Sentry. |
Changes
https://github.com/open-telemetry/semantic-conventions/releases/tag/v1.27.0
https://github.com/open-telemetry/build-tools/releases/tag/v0.25.0
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes