chore: update semantic convention version v1.27.0 #2000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lalitb
commented
Aug 7, 2024
| @@ -35,7 +35,7 @@ docker run --rm \ | |||
| -v "${CRATE_DIR}/scripts/templates:/templates" \ | |||
| -v "${CRATE_DIR}/src:/output" \ | |||
| otel/semconvgen:$SEMCOVGEN_VERSION \ | |||
| --only span,event,scope \ | |||
There was a problem hiding this comment.
scope type is removed from latest build-tool, and is unused - open-telemetry/build-tools#309
…st into sem-conv-v1.27.0
|
Moving to draft to fix the build error |
lalitb
commented
Aug 8, 2024
| @@ -14,7 +14,9 @@ | |||
| {%- set attribute = (attrs | selectattr('deprecated', 'none') | first) %} | |||
| {%- set attribute = attribute if attribute else (attrs | first) %} | |||
| {%- if conventions != 'attribute' %} | |||
| {%- if not attribute.deprecated %} | |||
There was a problem hiding this comment.
conditional check to ensure that the deprecated constants only defined with #[deprecated] annotation, and not exported.
should be good now. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2000 +/- ##
=======================================
- Coverage 75.1% 75.1% -0.1%
=======================================
Files 122 122
Lines 20642 20642
=======================================
- Hits 15506 15505 -1
- Misses 5136 5137 +1 ☔ View full report in Codecov by Sentry. |
cijothomas
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
https://github.com/open-telemetry/semantic-conventions/releases/tag/v1.27.0
https://github.com/open-telemetry/build-tools/releases/tag/v0.25.0
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes