Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix metrics counter benchmarks #1990

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Fix metrics counter benchmarks #1990

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions opentelemetry-sdk/benches/metric_counter.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,13 +32,13 @@ thread_local! {

// Run this benchmark with:
// cargo bench --bench metric_counter
fn create_counter() -> Counter<u64> {
fn create_counter(name: &'static str) -> Counter<u64> {
let meter_provider: SdkMeterProvider = SdkMeterProvider::builder()
.with_reader(ManualReader::builder().build())
.build();
let meter = meter_provider.meter("benchmarks");

meter.u64_counter("counter_bench").init()
meter.u64_counter(name).init()
}

fn criterion_benchmark(c: &mut Criterion) {
Expand All @@ -51,8 +51,8 @@ fn counter_add(c: &mut Criterion) {
"value10",
];

let counter = create_counter();
c.bench_function("Counter_Add_Sorted", |b| {
let counter = create_counter("Counter_Add_Sorted");
b.iter(|| {
// 4*4*10*10 = 1600 time series.
let rands = CURRENT_RNG.with(|rng| {
Expand Down Expand Up @@ -81,6 +81,7 @@ fn counter_add(c: &mut Criterion) {
});

c.bench_function("Counter_Add_Unsorted", |b| {
let counter = create_counter("Counter_Add_Unsorted");
b.iter(|| {
// 4*4*10*10 = 1600 time series.
let rands = CURRENT_RNG.with(|rng| {
Expand Down Expand Up @@ -108,11 +109,13 @@ fn counter_add(c: &mut Criterion) {
});
});

// Cause overflow.
for v in 0..2001 {
counter.add(100, &[KeyValue::new("A", v.to_string())]);
}
c.bench_function("Counter_Overflow", |b| {
let counter = create_counter("Counter_Overflow");
// Cause overflow.
for v in 0..2001 {
counter.add(100, &[KeyValue::new("A", v.to_string())]);
}

b.iter(|| {
// 4*4*10*10 = 1600 time series.
let rands = CURRENT_RNG.with(|rng| {
Expand Down
Loading